Make spatial grids entities - #248
Merged
Merged
Conversation
tychedelia
added this pull request to stack #256
September 29, 2026 04:50
tychedelia
removed this pull request from stack #256
September 29, 2026 05:06
tychedelia
added this pull request to stack #258
September 29, 2026 05:06
tychedelia
force-pushed
the
grid-entities
branch
from
September 29, 2026 05:55
2b94604 to
311e225
Compare
|
Visual regression: no changes across 43 cases baseline |
tychedelia
force-pushed
the
grid-entities
branch
from
September 29, 2026 18:45
311e225 to
2767eae
Compare
catilac
self-requested a review
October 5, 2026 14:22
catilac
approved these changes
Oct 5, 2026
catilac
left a comment
catilac
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Approving, but I do have a question about grid_count.wgsl and grid_scatter.wgsl
| dims_z: u32, | ||
| _pad: u32, | ||
| } | ||
| import processing::particles::{Grid, cell_coords, cell_index}; |
Contributor
There was a problem hiding this comment.
Should grid_count.wgsl and grid_scatter.wgsl also use this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grids were special cased, but they can just be another entity/component. We also can now specialize them when you do
compute.set("grid", grid)rather than having a separate grid binding API.